Selection menu #377
Draft
Selection menu #377
+589
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what the menu looks like currently: |
|
Very nice! An animation would be nice, as most other websites have that. Is there a color difference right now between the on and off states? I think it would be cool if the on-state color matched your color theme! For inspiration: 
|
|
|
|
That looks really good! |
|
There is a thin line of white pixels between the colored area and the border. Is it due to rounding error? How can I fix it?
|
|
It just looks like its an issue with using outline. Could we get it work work with a border instead? |
Perhaps a white button would look better for our light theme. Similar to these. The off-state background color could be a tad darker tho imo
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds selection menu with toggle switches to disable dragging pieces and premoves.
Relates to #22 and #328
Don't merge until after #350
To do
How do you want the menu to look?
Possible ideas